New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
display placeholder for video-widget #3885
display placeholder for video-widget #3885
Conversation
PRO-3145 Implement standard placeholder for video widgets, option to override
Same person who does this should also do PRO-3144 . Acceptance criteria
|
37b7a4f
to
583d327
Compare
馃И Unit tests will be added after #3886 is merged. |
<img | ||
src="{{ apos.asset.url(data.manager.options.placeholderUrl) }}" | ||
alt="image placeholder" | ||
width="100%" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same concern. Use a class, provide default styles that can be overridden.
583d327
to
071975b
Compare
126fd8f
to
33b6e01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1a2b8f6
to
4dc0454
Compare
4dc0454
to
e564044
Compare
Depends on #3882
Summary
Display a default placeholder image when adding a video widget.
What are the specific steps to test this change?
On testbed:
馃憠 the initial modal should not appear
馃憠 the default placeholder video should have been added:
馃憠 when you actually set a video for that widget, it should replace the placeholder
placeholderUrl
option in image widget:馃憠 you should have your video as placeholder now, instead of the default one
馃憠 all of these tests should be effective inside another widget such as the
two-column-widget
(nesting)馃憠 all of these tests should be effective in the page editor modal
What kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements:
If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.
Other information: