Don't fail on template missing parameters #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doesn't oc process fails when there are no parameters? |
|
Also look at the history. This error was added due to a problem we had... |
no
history says that much... do you know what was the error? maybe it was you trying to loop a NoneType? |
apahim
force-pushed
the
allow_missing_params
branch
from
718dd3c
to
130694a
Compare
|
I only found this PR: #864. I didn't link any issues in it, but i believe it was about trying to look into the parameters which didn't exist. |
|
thanks! |
The parameters are no really mandatory. Let's not fail when they are not present in the template. Signed-off-by: Amador Pahim <apahim@redhat.com>
apahim
force-pushed
the
allow_missing_params
branch
from
130694a
to
a13a54d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parameters are no really mandatory. Let's not fail when they are not
present in the template.
Signed-off-by: Amador Pahim apahim@redhat.com