-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
catch issues with integrations that use oc_map.get() #1232
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arilivigni
changed the title
catch issues with integrations that use oc_map.get(cluster)
catch issues with integrations that use oc_map.get()
Dec 8, 2020
apahim
reviewed
Dec 9, 2020
apahim
reviewed
Dec 9, 2020
apahim
reviewed
Dec 9, 2020
apahim
reviewed
Dec 9, 2020
apahim
reviewed
Dec 9, 2020
apahim
reviewed
Dec 9, 2020
apahim
reviewed
Dec 9, 2020
apahim
reviewed
Dec 9, 2020
apahim
reviewed
Dec 9, 2020
apahim
requested changes
Dec 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good. A couple of fixes and I believe we will be good to go.
apahim
reviewed
Dec 9, 2020
apahim
approved these changes
Dec 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After making the changes for unreachable clusters there are several integrations that end up calling the OC class and specifically
oc_map.get()
without these fixes, these integrations get stack traces and error.Amador found some of these issues and I also did some searching to find out all the places this method is used. These incorporate those changes.
Amador also noted that there was an issue with sql-query, but I was unable to reproduce:
I put this in my local app-interface
data/app-interface/sql-queries/app-sre/2020-12-07-dashdotdb-stage-clusters.yml
APP_INTERFACE_STATE_BUCKET_ACCOUNT=app-sre APP_INTERFACE_STATE_BUCKET=app-interface-production qontract-reconcile --config ../config.debug.toml --dry-run --log-level INFO sql-query
Please provide feedback since I am sure some of this can be done better.