-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature request]: Add TimeProvider argument to resilience extension methods #1983
Comments
Could you clarify exactly which methods you want this added to? If it's the |
The methods I was referring to were |
I don't seem to be able to find Polly/src/Polly.Extensions/DependencyInjection/PollyServiceCollectionExtensions.cs Line 101 in 82474bf
|
@silkfire If Polly/src/Polly.Extensions/DependencyInjection/PollyServiceCollectionExtensions.cs Line 282 in 82474bf
|
Apologies, it was late and I got the methods mixed up. The one I intended was
Interesting, I wasn't aware of that, this might actually be sufficient for my use case. Thank you. |
Is your feature request related to a specific problem? Or an existing feature?
When creating a ResiliencePipelineBuilder, the consumer is offered to set a custom ITimeProvider by setting the TimeProvider property on the builder. This is not possible when using e.g. HTTP resilience extension methods like AddStandardResilienceHandler as the builder is created internally.
Describe the solution you'd like
It'd be useful if an overload was provided that allows the consumer of the extension methods to specify a ITimeProvider argument of their own choice, so as to increase flexibility for e.g. unit tests.
Additional context
No response
The text was updated successfully, but these errors were encountered: