[Feature request]: Add TimeProvider argument to resilience extension methods

[silkfire]

Is your feature request related to a specific problem? Or an existing feature?

When creating a ResiliencePipelineBuilder, the consumer is offered to set a custom ITimeProvider by setting the TimeProvider property on the builder. This is not possible when using e.g. HTTP resilience extension methods like AddStandardResilienceHandler as the builder is created internally.

Describe the solution you'd like

It'd be useful if an overload was provided that allows the consumer of the extension methods to specify a ITimeProvider argument of their own choice, so as to increase flexibility for e.g. unit tests.

Additional context

No response

[martincostello]

Could you clarify exactly which methods you want this added to?

If it's the AddStandardResilienceHandler() methods, they don't live in this repository but in dotnet/extensions.

[silkfire]

The methods I was referring to were AddStandardResiliencePipeline and AddResiliencePipeline. I wasn't actually aware that they belonged to a different repository. Should I open an issue there instead?

[martincostello]

I don't seem to be able to find AddStandardResiliencePipeline() in either repository with GitHub code search. AddStandardResilienceHandler() is in dotnt/extensions, where as AddResiliencePipeline() lives here.

Polly/src/Polly.Extensions/DependencyInjection/PollyServiceCollectionExtensions.cs

Line 101 in 82474bf

public static IServiceCollection AddResiliencePipeline<TKey>(

[martintmk]

@silkfire If TimeProvider is registered in the DI, the AddResiliencePipeline will automatically use and assign it:

Polly/src/Polly.Extensions/DependencyInjection/PollyServiceCollectionExtensions.cs

Line 282 in 82474bf

if (serviceProvider.GetService<TimeProvider>() is { } timeProvider)

[silkfire]

I don't seem to be able to find AddStandardResiliencePipeline() in either repository with GitHub code search. AddStandardResilienceHandler() is in dotnt/extensions, where as AddResiliencePipeline() lives here.

Polly/src/Polly.Extensions/DependencyInjection/PollyServiceCollectionExtensions.cs

Line 101 in 82474bf

public static IServiceCollection AddResiliencePipeline<TKey>(

Apologies, it was late and I got the methods mixed up. The one I intended was AddStandardResilienceHandler().

@silkfire If TimeProvider is registered in the DI, the AddResiliencePipeline will automatically use and assign it:

Polly/src/Polly.Extensions/DependencyInjection/PollyServiceCollectionExtensions.cs

Line 282 in 82474bf

if (serviceProvider.GetService<TimeProvider>() is { } timeProvider)

Interesting, I wasn't aware of that, this might actually be sufficient for my use case. Thank you.