Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #186

Merged
merged 3 commits into from
Mar 26, 2018
Merged

Update README.md #186

merged 3 commits into from
Mar 26, 2018

Conversation

1hella
Copy link
Contributor

@1hella 1hella commented Mar 26, 2018

Update some of the wording and grammar :)

@1hella
Update README.md
c7dbb56 
Update some of the wording and grammar :)
siddharthlatest
siddharthlatest requested changes Mar 26, 2018
View reviewed changes
Copy link
Member

@siddharthlatest siddharthlatest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There shouldn't be a hyphen b/w websockets and based or b/w scroll and based. Other changes look good.

@1hella
Copy link
Contributor Author

1hella commented Mar 26, 2018

@siddharthlatest Ok I changed those back

@siddharthlatest siddharthlatest merged commit 3e896fa into appbaseio:dev Mar 26, 2018
@siddharthlatest
Copy link
Member

Awesome, thanks for contributing! 🎉 🎉

Hope to see you around 👋

@1hella
Copy link
Contributor Author

1hella commented Mar 26, 2018

@siddharthlatest Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddharthlatest siddharthlatest siddharthlatest requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@1hella @siddharthlatest