This repository has been archived by the owner on Aug 14, 2020. It is now read-only.
repository2: fix manifest v2.2 layer ordering. #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for i := len(layerIDs) - 1; i > 0; i-- { | ||
| log.Debug("Generating layer ACI...") | ||
|
|
||
| log.Debug("Generating layer ACI...") |
There was a problem hiding this comment.
why did you move this outside the loop?
There was a problem hiding this comment.
Because if there's only one layer it won't be written.
There was a problem hiding this comment.
Oh, I noticed that it should be written for every layer, will fix. Thanks!
With docker manifest v2.2 and oci the layers are ordered from the base layer to the topmost layer.
sgotti
force-pushed
the
fix_manifestv22_layer_order
branch
from
b8493e0
to
01cd929
Compare
|
I confirm this fixes troublesome containers that we've got reported so far, and LGTM (but I don't have any super-power here). |
|
wrt duplicate layers, @sgotti privately pointed out that distribution/distribution#1527 is a relevant reference. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With docker manifest v2.2 and oci the layers are ordered from the base layer to
the topmost layer.
This is just a quick fix for review. Next steps will be to add tests and remove duplicated layers.
Fixes #189