spec pods: Clarify empty volume kind #449
Conversation
|
This clarification is needed to unblock some rkt work: rkt/rkt#1040 |
|
👍 Question of a volume lifetime seems to be dependent on #276 (define "pod exits"), so I'd say it's out of scope now. |
|
LGTM. @thockin ? |
|
@kibra can you rewrite your commit message please - Clearify --> Clarify |
|
@jonboulle Fixed, thanks for the catch. |
jonboulle
changed the title
|
@jonboulle Ping. I'm not super happy with my language here, but I think it's a least a step forward. Let me know if there's something you think I should change. |
| * **kind** (string, required) either "empty" or "host". "empty" fulfills a mount point by ensuring the path exists (i.e., writes go to the app's chroot). "host" fulfills a mount point with a bind mount from a **source**. | ||
| * **readOnly** (boolean, optional, defaults to "false" if unsupplied) whether or not the volume will be mounted read only. | ||
| * **kind** (string, required) either: | ||
| * **empty** - creates an empty directory on the host and bind mounts it into the container. All containers in the pod share the mount, and the lifetime of the volume is equal to the lifetime of the pod (i.e. the directory on the host machine is removed when the pod exits) |
There was a problem hiding this comment.
(i.e. the directory on the host machine is removed when the pod exits)
This makes me a little uneasy. How about "the directory on the host machine is removed when the pod's filesystem is garbage collected"
There was a problem hiding this comment.
@jonboulle Agreed. That makes much more sense.
|
@kibra One more tweak then LGTM |
|
@jonboulle Thanks for the feed back. I've updated my PR. |
|
thanks! |
spec pods: Clarify empty volume kind
The spec for the "empty" volume kind is unclear. See #183 for the issue/discussion around this.
Note: My change proposes the rather strong spec of:
lifetime of the empty volume == lifetime of the podI feel that this makes the use case of "empty" more clear than specifying
lifetime of the empty volume >= lifetime of the podas was suggested in #183 (comment) However, I don't have a strong opinion around this, and would be happy to change what I wrote.