feat(ios): macOS support #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
You are seriously awesome man!! |
|
|
||
| // | ||
| // THESE SHOULD BE OK GENERALLY AS-IS | ||
| // | ||
| TITANIUM_SDK = /Users/$(USER)/Library/Application Support/Titanium/mobilesdk/osx/$(TITANIUM_SDK_VERSION) | ||
| HEADER_SEARCH_PATHS = $(inherited) "$(TITANIUM_SDK)/iphone/include" | ||
| FRAMEWORK_SEARCH_PATHS = $(inherited) "$(TITANIUM_SDK)/iphone/Frameworks" | ||
| FRAMEWORK_SEARCH_PATHS = $(inherited) "$(TITANIUM_SDK)/iphone/Frameworks/**" |
There was a problem hiding this comment.
I remember that I faced some issue with this while building module (probably it was picking other architecture found inside TitaniumKit.xcframework e.g building for simulator it was picking device's framework) because it is searching framework recursively. But it is working fine now. May be some issue from my side.
Probably we want to update _buildModule.js in SDK PR tidev/titanium-sdk#11955 to update this line at run time if it is getting build using SDK 9.2.0 (sdk version in which mac support included).
This was referenced Sep 2, 2020
Now that frameworks are xcframeworks, need to look recursively
rolls up ios major ver rev to 4.0.0
sgtcoolguy
force-pushed
the
mac-support
branch
from
915fe4a
to
05b66a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs to be built with SDK from master (Relied on changes from tidev/titanium-sdk#12033 to support xcframeworks and macOS)
This is PR gets the module building with the SDK that enables macOS support and builds as an xcframework (to support arm64 sims when Apple Silicon computers ship!). I've tested locally (and pushed fixes to the SDK) to get this working. I was able to test an iPhone sim and macOS catalyst locally.
The most relevant change here is to the
iOS/titanium.xcconfigusing a recursive path forFRAMEWORK_SEARCH_PATHS. Because the SDK packages TitaniumKit as an XCFramework, the underlying framework folders are underneath each os/arch combo parent.