-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ios): macOS support #16
Conversation
|
541ebb7
to
f995f3e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sgtcoolguy Code changes looks good. But build is failing. I guess proper SDK version should be included.
@vijaysingh-axway It's due to the CLI mangling the symlinks: https://jira.appcelerator.org/browse/TIMOB-28128 |
Needs to be built with SDK from master (Relied on changes from tidev/titanium-sdk#12033 to support xcframeworks and macOS)
This is PR gets the module building with the SDK that enables macOS support and builds as an xcframework (to support arm64 sims when Apple Silicon computers ship!). I've tested locally (and pushed fixes to the SDK) to get this working. I was able to test an iPhone sim and macOS catalyst locally.
The most relevant change here is to the
iOS/titanium.xcconfig
using a recursive path forFRAMEWORK_SEARCH_PATHS
. Because the SDK packages TitaniumKit as an XCFramework, the underlying framework folders are underneath each os/arch combo parent.Note that I also had to manually drag/drop the TitaniumKit.xcframework and then hack the file path in the Xcode project. The project fails in Xcode as a result, but builds via our CLI fine.
Related: