Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 9_3_X] feat(ios): use/support/build xcframeworks #12033

Merged
merged 6 commits into from
Sep 10, 2020
Merged

[Backport 9_3_X] feat(ios): use/support/build xcframeworks #12033

merged 6 commits into from
Sep 10, 2020

Conversation

build
Copy link
Contributor

@build build commented Sep 10, 2020

Backport of #12026.
See that PR for full details.

vijaysingh-axway and others added 6 commits September 10, 2020 15:46
@vijaysingh-axway @github-actions
build(ios): update APS libraries, tiverify to xcframework
1ee3f93 
- https://github.com/appcelerator/aps_sdk/pull/347
- tidev/APSHTTPClient#54
- https://github.com/appcelerator/titanium_verify/pull/33
@sgtcoolguy @github-actions
refactor(ios): guard APIs for mac catalyst target
51434da
@sgtcoolguy @github-actions
chore(ios)!: set minimum xcode to 11.x
2c43a41 
Fixes TIMOB-28072
@sgtcoolguy @github-actions
feat(ios): use/support/build xcframeworks
6dc7bb0
@sgtcoolguy @github-actions
fix(ios): exclude arm64 arch for sim target if native modules aren't …
59994a0 
…xcframeworks

Modules built before xcframework support do not have an arm64 sim arch/target
To avoid having to break all modules, we'll try and exclude arm64 from sim builds
This will eventually break if app is built on arm64 apple silicon and a new
xcframework based module hasn't been shipped.
@sgtcoolguy @github-actions
feat(ios): build modules as xcframeworks (w/ macos support)
23bbc36 
- preserve symlinks in module xcframeworks/zips
@build build added this to the 9.3.0 milestone Sep 10, 2020
@build build requested a review from a team September 10, 2020 16:06
@build
Copy link
Contributor Author

build commented Sep 10, 2020

Warnings
⚠️ There is no linked JIRA ticket in the PR body. Please include the URL of the relevant JIRA ticket. If you need to, you may file a ticket on JIRA
⚠️

iphone/cli/hooks/frameworks.js#L60 - iphone/cli/hooks/frameworks.js line 60 – Avoid calling back inside of a promise. (promise/no-callback-in-promise)
⚠️

iphone/cli/hooks/frameworks.js#L60 - iphone/cli/hooks/frameworks.js line 60 – Expected catch() or return (promise/catch-or-return)
⚠️

iphone/cli/hooks/frameworks.js#L79 - iphone/cli/hooks/frameworks.js line 79 – Avoid wrapping return values in Promise.resolve (promise/no-return-wrap)
⚠️

iphone/cli/hooks/frameworks.js#L429 - iphone/cli/hooks/frameworks.js line 429 – Each then() should return a value or throw (promise/always-return)
Messages
📖

💾 Here's the generated SDK zipfile.
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 7418 tests are passing.
(There are 693 skipped tests not included in that total)

Generated by 🚫 dangerJS against 23bbc36

@sgtcoolguy sgtcoolguy merged commit c938108 into tidev:9_3_X Sep 10, 2020
This was referenced Sep 11, 2020
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature in-qe-testing 🕵 ios no tests
Projects
None yet
Milestone
9.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@build @sgtcoolguy @vijaysingh-axway