feat(ios): macOS support #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sgtcoolguy
force-pushed
the
mac-support
branch
from
541ebb7
to
f995f3e
Compare
vijaysingh-axway
approved these changes
Sep 11, 2020
There was a problem hiding this comment.
@sgtcoolguy Code changes looks good. But build is failing. I guess proper SDK version should be included.
|
@vijaysingh-axway It's due to the CLI mangling the symlinks: https://jira.appcelerator.org/browse/TIMOB-28128 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs to be built with SDK from master (Relied on changes from tidev/titanium-sdk#12033 to support xcframeworks and macOS)
This is PR gets the module building with the SDK that enables macOS support and builds as an xcframework (to support arm64 sims when Apple Silicon computers ship!). I've tested locally (and pushed fixes to the SDK) to get this working. I was able to test an iPhone sim and macOS catalyst locally.
The most relevant change here is to the
iOS/titanium.xcconfigusing a recursive path forFRAMEWORK_SEARCH_PATHS. Because the SDK packages TitaniumKit as an XCFramework, the underlying framework folders are underneath each os/arch combo parent.Note that I also had to manually drag/drop the TitaniumKit.xcframework and then hack the file path in the Xcode project. The project fails in Xcode as a result, but builds via our CLI fine.
Related: