Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(ios): build against SDK w/ macos support #60

Merged
merged 6 commits into from Sep 14, 2020

Conversation

sgtcoolguy
Copy link
Contributor

@sgtcoolguy sgtcoolguy commented Sep 1, 2020

Needs to be built with SDK from master (Relied on changes from tidev/titanium-sdk#12033 to support xcframeworks and macOS)

This is PR gets the module building with the SDK that enables macOS support and builds as an xcframework (to support arm64 sims when Apple Silicon computers ship!). I've tested locally (and pushed fixes to the SDK) to get this working. I was able to test an iPhone sim and macOS catalyst locally.

The most relevant change here is to the iOS/titanium.xcconfig using a recursive path for FRAMEWORK_SEARCH_PATHS. Because the SDK packages TitaniumKit as an XCFramework, the underlying framework folders are underneath each os/arch combo parent.

NOTE This actually just worked as expected on my local MacBook Pro - the example app prompted me for TouchID and authenticated!

Screen Shot 2020-09-01 at 3 51 59 PM

Screen Shot 2020-09-01 at 3 52 10 PM

@sgtcoolguy
Copy link
Contributor Author

Relates to tidev/ti.map#309

@build
Copy link

build commented Sep 1, 2020

Warnings
⚠️ guid is inconsistent across platforms. It is c3d987a8-8bd4-42cd-a3e4-2a75952d1ea0 in android/manifest and ae6ffc93-6e6e-4251-8373-b0cb263a1662 in ios/manifest
⚠️ SDK version declared in Jenkinsfile (9.2.0.v20200911073932) does not match iOS' titanium.xcconfig value (9.2.0.GA)
Messages
📖

💾 Here are the artifacts produced:

📖

✅ All tests are passing
Nice one! All 103 tests are passing.

📖 🎉 - congrats on your new release

Generated by 🚫 dangerJS against 356ec0c

@sgtcoolguy sgtcoolguy marked this pull request as ready for review September 11, 2020 17:17
Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR passed!

@sgtcoolguy sgtcoolguy merged commit 819499a into tidev:master Sep 14, 2020
@sgtcoolguy sgtcoolguy deleted the mac-support branch September 14, 2020 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants