[TIMOB-25059] Use module hooks instead of plugins #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves all the platform specific Hyperloop plugins to the module's hooks folder so we don't need to explicitly register a plugin anymore. Also updates the local build script as well as the Jenkins build to handle the new directory structure. This also gets rid of all the manual plugin packaging.
janvennemann
force-pushed
the
TIMOB-25059
branch
from
ed2bcd6
to
733d94b
Compare
This shouldn't have been commited in the first place, but the .gitignore wasn't properly updated, duh!
hansemannn
reviewed
Nov 2, 2017
hooks/hyperloop-init.js
Outdated
| exports.cliVersion = '>=3.2'; | ||
| exports.init = (logger, config, cli, appc) => { | ||
| cli.on('cli:check-plugins', () => { | ||
| for (const plugin of cli.tiapp.plugins) { |
There was a problem hiding this comment.
I'm trying to use for...of whenever possible because it allows break and continue logic and doesn't overrides the context because no new function is created.
hansemannn
reviewed
Nov 2, 2017
hooks/hyperloop-init.js
Outdated
| cli.on('cli:check-plugins', () => { | ||
| for (const plugin of cli.tiapp.plugins) { | ||
| if (plugin.id === 'hyperloop') { | ||
| logger.error('Legacy Hyperloop plugin detected! Please remove any references to the Hyperloop plugin tag from your tiapp.xml. Since Hyperloop 3.0 you only need to enable it as a module.'); |
There was a problem hiding this comment.
Maybe phrase it Hyperloop "<plugin>" tag ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-25059
Moves all the platform specific Hyperloop plugins to the module's hooks folder so we don't need to explicitly register a plugin anymore. Also updates the local build script as well as the Jenkins build to handle the new directory structure. This also gets rid of all the manual plugin packaging.