fix(ios): Added missing flag to code sign TitaniumKit so device builds work again. #10505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s work again. Fixes TIMOB-26520.
cb1kenobi
changed the title
Generated by 🚫 dangerJS |
Note: subsequent builds are still broken due to code sign issue. TIMOB-26520
|
@cb1kenobi can you fix the linting issues? Is this ready to be merged or are more changes required? |
|
@janvennemann As stated in the description and in standup, I'm still working on this. |
|
@janvennemann This PR is now ready for test. |
ssjsamir
approved these changes
Dec 19, 2018
Brianggalvez
pushed a commit
to Brianggalvez/titanium_mobile
that referenced
this pull request
Dec 31, 2018
* source/master: (1616 commits) [TIMOB-26537] Android: Module "AndroidManifest.xml" <uses> elements overwrites "tiapp.xml" elements (tidev#10467) fix(ios): test for refresh control usage (tidev#10550) fix: standardize os.arch values to Node.js equivalents feat(api): add node-compatible os core module docs: add totalMemory(), cpus() and uptime to Ti.Platform feat(ios): add totalMemory() method and uptime property to Ti.Platform feat(android): add totalMemory() method, cpus() method and uptime property to Ti.Platform chore(android): remove deprecated Geolocation properties (tidev#10547) fix(ios): Set transitionIsAnimating while pushing the controller rather waiting for delegate (tidev#10535) fix(ios) : Convert property ‘value’ to string inside hasText function (tidev#10521) fix(ios): Added missing flag to code sign TitaniumKit so device builds work again. (tidev#10505) [TIMOB-26585] Android: Catch all TCP socket read and write exceptions (tidev#10490) [TIMOB-26095] iOS 12: Replace UIWebView API in favor of WKWebView (tidev#10169) chore: update node-titanium-sdk (tidev#10548) fix(android): Fix for splashscreen activity with translucent status bar. (tidev#10536) core(deps): Add danger-plugin-dependencies chore: migrate latest tests to suite chore(package): update lockfile package-lock.json chore(package): update @seadub/danger-plugin-junit to version 0.0.2 test: migrate tests to common suite ... # Conflicts: # apidoc/Titanium/UI/ListView.yml # iphone/Classes/TiUIListView.h # iphone/Classes/TiUIListView.m # iphone/Classes/TiUIListViewProxy.m
|
A jira bug (https://jira.appcelerator.org/browse/TIMOB-26520) send me there, I still figure the problem when building with SDK 8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing flag to code sign TitaniumKit so device builds work again.
Fixes TIMOB-26520.
JIRA: https://jira.appcelerator.org/browse/TIMOB-26520
Note: this regression was introduced when PR #10218 (TIMOB-25927) landed.