Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-26585] Android: Catch all TCP socket read and write exceptions #10490

Merged
merged 6 commits into from Dec 19, 2018
Merged

[TIMOB-26585] Android: Catch all TCP socket read and write exceptions #10490

merged 6 commits into from Dec 19, 2018

Conversation

garymathews
Copy link
Contributor

  • Catch all readySync and writeSync exceptions
  • Close socket upon release

JIRA Ticket

@garymathews garymathews added this to the 8.0.0 milestone Nov 26, 2018
@build
Copy link
Contributor

build commented Nov 26, 2018 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.
📖

✅ All tests are passing
Nice one! All 2903 tests are passing.

Generated by 🚫 dangerJS

jquick-axway
jquick-axway approved these changes Nov 26, 2018
View reviewed changes
Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@lokeshchdhry
Copy link
Contributor

@garymathews , Now I don't get the exception. But I think the issue is not fully fixed. I still do get in console Address in use, retrying... and live view does not reload the app even though console says reload triggered due to change. Earlier, even with the exception reload worked fine.

@jquick-axway
Copy link
Contributor

jquick-axway commented Nov 26, 2018 •
edited

I don't think this is a regression in our TCP socket object. This error will happen when you attempt to read/write to a closed socket, which can happen in an older Titanium version too.

Perhaps this is an issue in LiveView or our app restart code?

@lokeshchdhry lokeshchdhry merged commit 1699589 into tidev:master Dec 19, 2018
Brianggalvez pushed a commit to Brianggalvez/titanium_mobile that referenced this pull request Dec 31, 2018
Merge remote-tracking branch 'source/master'
6dd071c 
* source/master: (1616 commits)
  [TIMOB-26537] Android: Module "AndroidManifest.xml" <uses> elements overwrites "tiapp.xml" elements (tidev#10467)
  fix(ios): test for refresh control usage (tidev#10550)
  fix: standardize os.arch values to Node.js equivalents
  feat(api): add node-compatible os core module
  docs: add totalMemory(), cpus() and uptime to Ti.Platform
  feat(ios): add totalMemory() method and uptime property to Ti.Platform
  feat(android): add totalMemory() method, cpus() method and uptime property to Ti.Platform
  chore(android): remove deprecated Geolocation properties (tidev#10547)
  fix(ios): Set transitionIsAnimating while pushing the controller rather waiting for delegate (tidev#10535)
  fix(ios) : Convert property ‘value’ to string inside hasText function (tidev#10521)
  fix(ios): Added missing flag to code sign TitaniumKit so device builds work again. (tidev#10505)
  [TIMOB-26585] Android: Catch all TCP socket read and write exceptions (tidev#10490)
  [TIMOB-26095] iOS 12: Replace UIWebView API in favor of WKWebView (tidev#10169)
  chore: update node-titanium-sdk (tidev#10548)
  fix(android): Fix for splashscreen activity with translucent status bar. (tidev#10536)
  core(deps): Add danger-plugin-dependencies
  chore: migrate latest tests to suite
  chore(package): update lockfile package-lock.json
  chore(package): update @seadub/danger-plugin-junit to version 0.0.2
  test: migrate tests to common suite
  ...

# Conflicts:
#	apidoc/Titanium/UI/ListView.yml
#	iphone/Classes/TiUIListView.h
#	iphone/Classes/TiUIListView.m
#	iphone/Classes/TiUIListViewProxy.m
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jquick-axway jquick-axway jquick-axway approved these changes

Assignees
No one assigned
Labels
android bug in-qe-testing 🕵 no tests
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@garymathews @build @lokeshchdhry @jquick-axway