fix(ios) : Convert property ‘value’ to string inside hasText function #10521
Conversation
Generated by 🚫 dangerJS |
|
|
||
| win.add(textFieldB); | ||
|
|
||
| textFieldA.addEventListener('change', function () { |
There was a problem hiding this comment.
What's the change event listener for? How will it be triggered in a unit test?
There was a problem hiding this comment.
When value get set , at that time also 'change' event listener get called.
There was a problem hiding this comment.
This event will only be triggered by user input, not when changing the text programmatically.
There was a problem hiding this comment.
In this particular case when we set number, 'change' event listener is getting called. I guess you are correct, ideally it should not call if it set programatically.
Though I have updated unit test, I'll create a ticket to check the behaviour of 'change' event listener.
There was a problem hiding this comment.
For verifying the conversion of 0 to "0" -
There is no getter method implemented in this to get value from textfield. Whenever we call getter it will simply fetch value from proxy (default getter). So with getter it will always give the same value, which is number. Other places also I can see default getter (value from proxy) returned.
|
FR Passed.
Studio Ver: 5.1.2.201810301430 |
* source/master: (1616 commits) [TIMOB-26537] Android: Module "AndroidManifest.xml" <uses> elements overwrites "tiapp.xml" elements (tidev#10467) fix(ios): test for refresh control usage (tidev#10550) fix: standardize os.arch values to Node.js equivalents feat(api): add node-compatible os core module docs: add totalMemory(), cpus() and uptime to Ti.Platform feat(ios): add totalMemory() method and uptime property to Ti.Platform feat(android): add totalMemory() method, cpus() method and uptime property to Ti.Platform chore(android): remove deprecated Geolocation properties (tidev#10547) fix(ios): Set transitionIsAnimating while pushing the controller rather waiting for delegate (tidev#10535) fix(ios) : Convert property ‘value’ to string inside hasText function (tidev#10521) fix(ios): Added missing flag to code sign TitaniumKit so device builds work again. (tidev#10505) [TIMOB-26585] Android: Catch all TCP socket read and write exceptions (tidev#10490) [TIMOB-26095] iOS 12: Replace UIWebView API in favor of WKWebView (tidev#10169) chore: update node-titanium-sdk (tidev#10548) fix(android): Fix for splashscreen activity with translucent status bar. (tidev#10536) core(deps): Add danger-plugin-dependencies chore: migrate latest tests to suite chore(package): update lockfile package-lock.json chore(package): update @seadub/danger-plugin-junit to version 0.0.2 test: migrate tests to common suite ... # Conflicts: # apidoc/Titanium/UI/ListView.yml # iphone/Classes/TiUIListView.h # iphone/Classes/TiUIListView.m # iphone/Classes/TiUIListViewProxy.m
https://jira.appcelerator.org/browse/TIMOB-26639