New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(android): remove deprecated Geolocation properties #10547
Conversation
Generated by 🚫 dangerJS |
f11da3d
to
14d888f
Compare
14d888f
to
1fc0c70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: Pass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FR Passed
Tested using the testcase above and modified version, geolocation is recorded successfully with and without ti.playservices
ENV
OnePlus 6t (9.0)
APPC CLI: 7.0.9-3
MacOS: 10.14.2
Node.js Version: 8.12.0
Xcode 10.1
* source/master: (1616 commits) [TIMOB-26537] Android: Module "AndroidManifest.xml" <uses> elements overwrites "tiapp.xml" elements (tidev#10467) fix(ios): test for refresh control usage (tidev#10550) fix: standardize os.arch values to Node.js equivalents feat(api): add node-compatible os core module docs: add totalMemory(), cpus() and uptime to Ti.Platform feat(ios): add totalMemory() method and uptime property to Ti.Platform feat(android): add totalMemory() method, cpus() method and uptime property to Ti.Platform chore(android): remove deprecated Geolocation properties (tidev#10547) fix(ios): Set transitionIsAnimating while pushing the controller rather waiting for delegate (tidev#10535) fix(ios) : Convert property ‘value’ to string inside hasText function (tidev#10521) fix(ios): Added missing flag to code sign TitaniumKit so device builds work again. (tidev#10505) [TIMOB-26585] Android: Catch all TCP socket read and write exceptions (tidev#10490) [TIMOB-26095] iOS 12: Replace UIWebView API in favor of WKWebView (tidev#10169) chore: update node-titanium-sdk (tidev#10548) fix(android): Fix for splashscreen activity with translucent status bar. (tidev#10536) core(deps): Add danger-plugin-dependencies chore: migrate latest tests to suite chore(package): update lockfile package-lock.json chore(package): update @seadub/danger-plugin-junit to version 0.0.2 test: migrate tests to common suite ... # Conflicts: # apidoc/Titanium/UI/ListView.yml # iphone/Classes/TiUIListView.h # iphone/Classes/TiUIListView.m # iphone/Classes/TiUIListViewProxy.m
TEST CASE
ti.playservices
intiapp.xml
JIRA Ticket