fix(ios): test for refresh control usage #10550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
ssjsamir
approved these changes
Dec 20, 2018
There was a problem hiding this comment.
FR Passed Application no longer crashes when using ScrollView without RefreshControl, Tested with the following test case
const win = Ti.UI.createWindow();
const scrollView = Ti.UI.createScrollView({
height: '80%',
width: '80%'
});
const view = Ti.UI.createView({
backgroundColor:'#336699',
borderRadius: 10,
top: 10,
height: 2000,
width: 1000
});
scrollView.add(view);
// Uncomment this to fix the build
//const refreshControl = Ti.UI.createRefreshControl();
//scrollView.refreshControl = refreshControl;
win.add(scrollView);
win.open();
Test Environment
APPC Studio: 5.1.0.201808080937
iPhone 8 (iOS 12.1)
APPC CLI: 7.0.8
Operating System Name: Mac OS Mojave
Operating System Version: 10.14.1
Node.js Version: 8.9.1
Xcode 10.1
Brianggalvez
pushed a commit
to Brianggalvez/titanium_mobile
that referenced
this pull request
Dec 31, 2018
* source/master: (1616 commits) [TIMOB-26537] Android: Module "AndroidManifest.xml" <uses> elements overwrites "tiapp.xml" elements (tidev#10467) fix(ios): test for refresh control usage (tidev#10550) fix: standardize os.arch values to Node.js equivalents feat(api): add node-compatible os core module docs: add totalMemory(), cpus() and uptime to Ti.Platform feat(ios): add totalMemory() method and uptime property to Ti.Platform feat(android): add totalMemory() method, cpus() method and uptime property to Ti.Platform chore(android): remove deprecated Geolocation properties (tidev#10547) fix(ios): Set transitionIsAnimating while pushing the controller rather waiting for delegate (tidev#10535) fix(ios) : Convert property ‘value’ to string inside hasText function (tidev#10521) fix(ios): Added missing flag to code sign TitaniumKit so device builds work again. (tidev#10505) [TIMOB-26585] Android: Catch all TCP socket read and write exceptions (tidev#10490) [TIMOB-26095] iOS 12: Replace UIWebView API in favor of WKWebView (tidev#10169) chore: update node-titanium-sdk (tidev#10548) fix(android): Fix for splashscreen activity with translucent status bar. (tidev#10536) core(deps): Add danger-plugin-dependencies chore: migrate latest tests to suite chore(package): update lockfile package-lock.json chore(package): update @seadub/danger-plugin-junit to version 0.0.2 test: migrate tests to common suite ... # Conflicts: # apidoc/Titanium/UI/ListView.yml # iphone/Classes/TiUIListView.h # iphone/Classes/TiUIListView.m # iphone/Classes/TiUIListViewProxy.m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-26668
Fix scroll view without usage of refresh control.
Regression was introduced by #10103