Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): documentViewer setAnnotation method causing a crash #12496

Merged
merged 10 commits into from Mar 17, 2021

Conversation

vijaysingh-axway
Copy link
Contributor

@build build added this to the 10.0.0 milestone Feb 24, 2021
@build build requested review from a team February 24, 2021 02:08
@build
Copy link
Contributor

build commented Feb 24, 2021

Fails
🚫 Tests have failed, see below for more information.
🚫

Test suite crashed on iOS simulator. Please see the crash log for more details.

Warnings
⚠️ This PR has milestone set to 10.0.0, but the version defined in package.json is 10.1.0 Please either: - Update the milestone on the PR - Update the version in package.json - Hold the PR to be merged later after a release and version bump on this branch
Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 4 tests have failed There are 4 tests failing and 735 skipped out of 11742 total tests.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.UI.View"after all" hook for "rgba fallback" (5.0.2)20.392
Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
android.emulator.Titanium.UI.View"after each" hook for "getOrCreateView() should always return a View" (5.0.2)10.368
Error: Timeout of 10000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
ios.iphone.Titanium.Network.HTTPClientdownloadLargeFile (14.4.0)0.09
Error: failed to retrieve large image: [object Object]
file:///ti.network.httpclient.test.js:84:25
ios.macos.Titanium.Network.HTTPClientdownloadLargeFile (10.15.7)0.089
Error: failed to retrieve large image: [object Object]
file:///ti.network.httpclient.test.js:84:25

Generated by 🚫 dangerJS against 6dab5a3

Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a test case (or several, for various annotation types) would be helpful here.

I had thought "old-style" proxies always got NSArray args, but I guess not?

@sgtcoolguy sgtcoolguy added backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge bug in-qe-testing 🕵 labels Mar 15, 2021
@sgtcoolguy sgtcoolguy self-requested a review March 16, 2021 14:06
@ssekhri
Copy link

ssekhri commented Mar 16, 2021

FR Passed.
Verified on:
Mac OS: 10.15.4
SDK: 10.1.0.v20210315123356
Appc CLI: 8.1.1
JDK: 11.0.6
Node: 12.16.1
Studio: 6.0.0.202005141803
Xcode: 12.3
iOS simulator v14.3

@build build removed the backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge label Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants