-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ios): xcode project change detection causing unnecessary rebuilds #12755
Conversation
Really cool fix, it works very well! Hope this can be cherry picked into GA |
Tests:
|
@jquick-axway May it be possible to include this in the 10.0.1 release? It improves the developer experience for larger projects massively. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: Pass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FR Pass. No longer seeing unnecessary rebuilds on kitchensink
JIRA:
https://jira.appcelerator.org/browse/TIMOB-28506
Summary:
This fixes two issues where our build was unnecessarily doing full Xcode re-builds...
.entitlements
with existing ones from Xcode extensions before overwriting. Otherwise they may differ just by a trailing newline for example and always cause a full re-build.Test: