New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(android): remove unneeded warnings #12783
Conversation
Tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: PASS
@garymathews, do you think I should remove our 10.0.0 deprecation code comments below. Our API docs do not document the above exception properties as deprecated. |
@jquick-axway I think we should make them deprecated in 10.1.0 since we forgot about them in 9.0.0 |
@@ -309,22 +309,22 @@ events: | |||
type: String | |||
platforms: [android] | |||
- name: lineOffset | |||
summary: The offset on the line where the error occurred. | |||
summary: The offset on the line where the error occurred. (Deprecated since 9.0.0. Use `column` instead.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can use the deprecated
attribute
deprecated:
since: "9.0.0"
notes: Use the `column` property instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The yml "deprecated" attribute is ignored for "event properties" in our old and new doc websites. Only the "summary" is used, which is why I'm duplicating this info there.
https://docs.appcelerator.com/platform/latest/#!/api/Titanium.App-event-uncaughtException
https://titaniumsdk.com/api/titanium/app.html#uncaughtexception
FR Passed. |
JIRA:
https://jira.appcelerator.org/browse/TIMOB-28441
Summary:
Synchronous invocation of write will cause performance issues under the main thread. This will no longer be supported in SDK 10.0.0. Please invoke with a final callback function to receive the result.
Could not open stream to get bitmap