Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(android): remove unneeded warnings #12783

Merged
merged 4 commits into from May 20, 2021

Conversation

jquick-axway
Copy link
Contributor

JIRA:
https://jira.appcelerator.org/browse/TIMOB-28441

Summary:

  • Remove below warning when calling blocking streaming API. We do not plan on removing this API in the future.
    Synchronous invocation of write will cause performance issues under the main thread. This will no longer be supported in SDK 10.0.0. Please invoke with a final callback function to receive the result.
  • Removed below image loading warning that needless spams the log. Calling code typically falls-back to the correct image path for cases where it has to guess the correct path. It's up to the caller to log an error or fire an error event.
    Could not open stream to get bitmap

@jquick-axway jquick-axway added android no tests backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge labels May 7, 2021
@jquick-axway jquick-axway added this to the 10.1.0 milestone May 7, 2021
@build build requested a review from a team May 7, 2021 05:33
@build
Copy link
Contributor

build commented May 7, 2021

Fails
🚫 Tests have failed, see below for more information.
🚫

Test suite crashed on iOS simulator. Please see the crash log for more details.

Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 3 tests have failed There are 3 tests failing and 677 skipped out of 11704 total tests.
📖 👍 Hey!, You deleted more code than you added. That's awesome!

Tests:

ClassnameNameTimeError
android.emulator.Titanium.Geolocation.methods#forwardGeocoder() works via callback argument (5.0.2)5.011
Error: expected false to be true
at Assertion.fail (/node_modules/should/cjs/should.js:275:13)
      at Assertion.value (/node_modules/should/cjs/should.js:356:9)
      at Geolocation.<anonymous> (/ti.geolocation.test.js:585:32)
ios.ipad.Titanium.UI.WebViewbeforeload (14.4.0)30
Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
ios.iphone.Titanium.UI.WebViewbeforeload (14.4.0)29.999
Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)

Generated by 🚫 dangerJS against ce19398

Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS

@jquick-axway
Copy link
Contributor Author

@garymathews
Copy link
Contributor

@jquick-axway I think we should make them deprecated in 10.1.0 since we forgot about them in 9.0.0

@build build added the docs label May 11, 2021
@@ -309,22 +309,22 @@ events:
type: String
platforms: [android]
- name: lineOffset
summary: The offset on the line where the error occurred.
summary: The offset on the line where the error occurred. (Deprecated since 9.0.0. Use `column` instead.)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can use the deprecated attribute

deprecated: 
    since: "9.0.0"
    notes: Use the `column` property instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The yml "deprecated" attribute is ignored for "event properties" in our old and new doc websites. Only the "summary" is used, which is why I'm duplicating this info there.
https://docs.appcelerator.com/platform/latest/#!/api/Titanium.App-event-uncaughtException
https://titaniumsdk.com/api/titanium/app.html#uncaughtexception

@lokeshchdhry
Copy link
Contributor

FR Passed.

@sgtcoolguy sgtcoolguy merged commit e98cc86 into tidev:master May 20, 2021
@build build removed the backport 10_2_X when applied, PRs with this label will get an auto-generated backport to 10_2_X branch on merge label May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants