[TIMOB-14399] scrollableview should call setActivity on its children #4402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Activity should also be updated in setViews and addView method. Otherwise the PR looks good. Will merge once updated. |
ghost
assigned 
|
Closing PR, please see #4668. |
|
I updated my PR to manage all cases correctly. You can a look at it (though i dont get why the last commit doesnt appear here :s) |
|
which PR did you updated? This one is closed and I don't see any new commits... Did you push your changes to remote? Seems like your changes may still be in the local branch. |
|
It s thiscommit. It s on the right branch but it doesnt want to appear here :s |
|
created another PR because this one wouldnt update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jira ticket