Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TIMOB-14399-Additional changes to original pull request #4668

Closed
wants to merge 1 commit into from
Closed

TIMOB-14399-Additional changes to original pull request #4668

wants to merge 1 commit into from

Conversation

salachi
Copy link
Contributor

@salachi salachi commented Sep 10, 2013

Added additional changes as per the review comments in the original request.

https://jira.appcelerator.org/browse/TIMOB-14399

@hieupham007 hieupham007 mentioned this pull request Sep 11, 2013
Closed
hieupham007
hieupham007 reviewed Sep 11, 2013
View reviewed changes
android/modules/ui/src/java/ti/modules/titanium/ui/ScrollableViewProxy.java
//Assign the activity to all the newly added views
Activity activity = getActivity();
if (activity != null) {
ArrayList<TiViewProxy> list = getView().getViews();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is repeat code from the setActivity() function. We should probably move it out to a separate function - perhaps call it setActivityForViews()

@farfromrefug
Copy link
Contributor

THis is not enough. What i did in my PR is to set the activity in TiUIScrollableView in addView and setViews.
But this is not enough. You need to do it on the setActivity method of the Proxy because you are not sure when this is called (View released …)
I dont know why my PR did not show the modification on the TiUIScrollableView. Will look into it

@salachi
Copy link
Contributor Author

salachi commented Sep 23, 2013

I submitted the PR because there was no activity regarding the comment in the original PR. If you are planning to fix the original PR, please go ahead, I can close this PR.

@farfromrefug
Copy link
Contributor

ok i created another PR as the old one wouldnt want to update
#4728

@vishalduggal
Copy link
Contributor

Closing this PR. PR #4728 merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@salachi @farfromrefug @vishalduggal @hieupham007