-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-14399] scrollableview should call setActivity on its children (second try) #4728
Conversation
Martin, I'm having trouble reproducing the fail case on 3.1.3.GA with 4.0.x, 4.1.x, 4.2.x and 2.3.x devices. On all devices I've tested, I'm seeing a blue window with 'Hello World' text after clicking on the button. I'm also seeing the same behavior when tested with this PR. Are you able to reproduce this on current master or 3.1.3.GA? |
Wow it s pretty far away and i cant reproduce it in my env. I am too far ahead. |
@@ -320,6 +320,7 @@ public void propertyChanged(String key, Object oldValue, Object newValue, | |||
public void addView(TiViewProxy proxy) | |||
{ | |||
if (!mViews.contains(proxy)) { | |||
proxy.setActivity(proxy.getActivity()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
proxy.setActivity(this.proxy.getActivity());
or proxy.setActivity(getProxy().getActivity());
CR Failed. Please address comments |
Thanks @vishalduggal |
CR ok. APPROVED |
[TIMOB-14399] scrollableview should call setActivity on its children (second try)
jira ticket
Another try as the other pull request wont update