Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-14399] scrollableview should call setActivity on its children (second try) #4728

Merged
merged 3 commits into from Sep 30, 2013
Merged

[TIMOB-14399] scrollableview should call setActivity on its children (second try) #4728

merged 3 commits into from Sep 30, 2013

Conversation

farfromrefug
Copy link
Contributor

jira ticket
Another try as the other pull request wont update

This was referenced Sep 23, 2013
Closed
Closed
@hieupham007
Copy link
Contributor

Martin, I'm having trouble reproducing the fail case on 3.1.3.GA with 4.0.x, 4.1.x, 4.2.x and 2.3.x devices. On all devices I've tested, I'm seeing a blue window with 'Hello World' text after clicking on the button. I'm also seeing the same behavior when tested with this PR. Are you able to reproduce this on current master or 3.1.3.GA?

@farfromrefug
Copy link
Contributor Author

Wow it s pretty far away and i cant reproduce it in my env. I am too far ahead.
But looking at the code in the master branch, there is no way this is fixed.
yet something might have changed in the activity lifecycle handle which makes it works in this case.

vishalduggal
vishalduggal reviewed Sep 27, 2013
View reviewed changes
android/modules/ui/src/java/ti/modules/titanium/ui/widget/TiUIScrollableView.java
@@ -320,6 +320,7 @@ public void propertyChanged(String key, Object oldValue, Object newValue,
public void addView(TiViewProxy proxy)
{
if (!mViews.contains(proxy)) {
proxy.setActivity(proxy.getActivity());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proxy.setActivity(this.proxy.getActivity()); or proxy.setActivity(getProxy().getActivity());

@vishalduggal
Copy link
Contributor

CR Failed. Please address comments

@farfromrefug
Copy link
Contributor Author

Thanks @vishalduggal

@vishalduggal
Copy link
Contributor

CR ok. APPROVED

vishalduggal added a commit that referenced this pull request Sep 30, 2013
@vishalduggal
Merge pull request #4728 from Akylas/TC-2494
a614d03 
[TIMOB-14399] scrollableview should call setActivity on its children (second try)
@vishalduggal vishalduggal merged commit a614d03 into tidev:master Sep 30, 2013
@farfromrefug farfromrefug deleted the TC-2494 branch October 1, 2013 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@farfromrefug @hieupham007 @vishalduggal