New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-23691] iOS: Expose statusBarBackgroundColor #8162
Conversation
Can one of the admins verify this patch? |
TiColor* newColor = [TiUtils colorValue:color]; | ||
statusbarBg.backgroundColor = [newColor _color]; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if that's the best way to go. I like the style proposed here: http://stackoverflow.com/a/34658477/5537752
Also, statusbarBg
should be released from memory every time it is set again, as well as in the dealloc
method to clean it from memory after the gets GC'd.
Please try the above-mentioned way to do it.
@hansemannn Wow, thank you! Pushed ;) |
Happy to hear. One thing that concerns me is, that we can set the |
And remove |
Mmm, theoretically we can just call the |
Right. Then please move it to |
Hi @hansemannn, I thought about, could be better to move to |
Excellent idea! Now please |
Can you please pull from master? Cloning your PR locally includes old stuff like the manual scons-scripts. |
Approved! |
JIRA: https://jira.appcelerator.org/browse/TIMOB-23691