feat: Make automatic screenshot taking configurable #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrmacete
changed the title
- disable by default - initial disabling avoidable by setting env var DISABLE_SCREENSHOTS=NO - overridable on session start via capability
mrmacete
force-pushed
the
auto-screenshot-config
branch
from
122077c
to
6b8db1d
Compare
So that the mere presence of ENABLE_AUTOMATIC_SCREENSHOTS in the env is enough to enable them, regardless of the env var value.
mykola-mokhnach
approved these changes
Mar 22, 2021
electricbubble
added a commit
to electricbubble/gwda
that referenced
this pull request
Mar 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disableAutomaticScreenshotscapabilityThe reason for this change is that sometimes it's useful to turn this feature back on for debugging purposes, especially when working on complex setups with remote devices.