Add sensors support #555
Merged
Add sensors support #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KazuCocoa
approved these changes
Jul 29, 2019
lib/commands/actions.js
Outdated
| * @param {number|string} value - Number to set as the sensor value. | ||
| * @throws {Error} - If deviceType is not an emulator | ||
| */ | ||
| commands.sensorSet = async function sensorSet (sensorType, value) { |
There was a problem hiding this comment.
which external API endpoint is supposed to trigger this method?
There was a problem hiding this comment.
@mykola-mokhnach this is something I want to discuss with the community. We have two options here;
- using one endpoint per type of sensor. For ex; W3C already has a method for light sensor in progress. https://www.w3.org/TR/ambient-light/
- using one endpoint for all sensors.
I'd like to hear you guys feedback. I'll probably start the conversation later today in slack
There was a problem hiding this comment.
I would say it is always safe to have a "mobile:" endpoint for such purpose
There was a problem hiding this comment.
Added a new mapping here: https://github.com/appium/appium-android-driver/pull/555/files#diff-2ac213fe13b12323b4767dd0bd037ee4R37
|
We should require |
|
LGTM. Do not forget to add the same mobile command to uia2 and espresso after this PR is published |
mykola-mokhnach
approved these changes
Aug 19, 2019
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare Android driver to support sensors set for Emulators implemented on ADB
appium/appium-adb#456