Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Align autoLaunch capability behaviour with iOS #676

Merged
merged 1 commit into from
Feb 7, 2021
Merged

fix: Align autoLaunch capability behaviour with iOS #676

merged 1 commit into from
Feb 7, 2021

Conversation

mykola-mokhnach
Copy link
Contributor

KazuCocoa
KazuCocoa approved these changes Feb 7, 2021
View reviewed changes
Copy link
Member

@KazuCocoa KazuCocoa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

appium-android-driver/lib/driver.js

Lines 284 to 291 in 15ffd8d

if (this.isChromeSession) {
// start a chromedriver session and proxy to it
await this.startChromeSession();
} else {
if (this.opts.autoLaunch) {
// start app
await this.startAUT();
}

@mykola-mokhnach mykola-mokhnach merged commit 64500c2 into appium:master Feb 7, 2021
@mykola-mokhnach mykola-mokhnach deleted the auto_launch branch February 7, 2021 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KazuCocoa KazuCocoa KazuCocoa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mykola-mokhnach @KazuCocoa