Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Align autoLaunch capability behaviour with iOS #440

Merged
merged 1 commit into from
Feb 7, 2021

Conversation

mykola-mokhnach
Copy link
Contributor

iOS does app install, but does not launch it, which makes more sense in the capability name context.

@mykola-mokhnach mykola-mokhnach changed the title fix: Align autoLaunch capapability behaviour with iOS fix: Align autoLaunch capability behaviour with iOS Feb 7, 2021
Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good.

if (this.isChromeSession) { // start a chromedriver session
await this.startChromeSession(this);
} else if (this.opts.autoLaunch && this.opts.appPackage) {
await this.ensureAppStarts();
}

is responsible for launching the app under test

@mykola-mokhnach mykola-mokhnach merged commit 8f195c6 into appium:master Feb 7, 2021
@mykola-mokhnach mykola-mokhnach deleted the auto_launch branch February 7, 2021 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants