This repository has been archived by the owner on Oct 25, 2023. It is now read-only.
refactor: Prefer event emitting to promises cancelation #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykola-mokhnach
changed the title
imurchie
reviewed
Nov 25, 2019
lib/basedriver/driver.js
Outdated
| * The function may accept one argument, which is the actual error instance, which | ||
| * caused the driver to shut down. | ||
| */ | ||
| onUnexpectedShutdown (hanlder) { |
|
@imurchie I can also observe the TODO at https://github.com/appium/appium/blob/67e85ff02ce0d9d1237912e38b207869431e7e07/lib/appium.js#L411 which we could possible resolve by this PR |
jlipps
approved these changes
Nov 25, 2019
4 tasks
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to appium/appium#13631 we still have memory leaks due to weird promise cancelation logic. IMHO promise cancelation itself is evil in its current implementation and I would rather avoid using it.
BREAKING CHANGE: The current refactoring is breaking and changes
onUnexpectedShutdownto a normal event, which is emitted by the driver when it is shut down unexpectedly. I've also checked the depending drivers and it looks like only the umbrella driver uses this promise, so we'll have to change that implementation after the major version bump