This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
fix: get filePaths #1521
Merged
fix: get filePaths #1521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| onClick={() => this.getLocalFilePath((filepath) => onSetCapabilityParam(filepath[0]))} />; | ||
| onClick={async () => { | ||
| const filePath = await this.getLocalFilePath(); | ||
| onSetCapabilityParam(filePath ? filePath : currentPath) ; |
There was a problem hiding this comment.
could be simplified to filePath || currentPath
There was a problem hiding this comment.
what is the purpose of calling onSetCapabilityParam with currentPath argument?
There was a problem hiding this comment.
To keep the current inputted path when file browsing was cancelled. Previous filepath behaviour (before #1492) also behaved as the same.
mykola-mokhnach
approved these changes
Aug 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/appium/appium-desktop/issues/1492
Not sure since when, but
showOpenDialogshould bethensyntax.this.handleSetTypeis alwaysnull, so cannot bind.After:
https://github.com/electron/electron/blob/v6.0.0/docs/api/dialog.md#dialogshowopendialogbrowserwindow-options