Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Windows devices #157

Closed
wants to merge 27 commits into from
Closed

Add support for Windows devices #157

wants to merge 27 commits into from

Conversation

stoneman
Copy link
Contributor

Change list

Add WindowsDriver and WindowsElement for use with https://github.com/appium/appium-windows-driver

Types of changes

What types of changes are you proposing/introducing to .NET client?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

Some methods throw NotImplementedExceptions due to https://github.com/Microsoft/WinAppDriver/ (and therefore https://github.com/appium/appium-windows-driver) not supporting the functionality.

@jlipps
Copy link
Member

jlipps commented Aug 19, 2016

👍 however lots of merges in the git log here

@TikhomirovSergey
Copy link
Contributor

Wow!
Will check it ASAP

@TikhomirovSergey
Copy link
Contributor

@JonStoneman @yodurr
Please provide licence header at new added files

return new WindowsElement(this, elementId);
}

public override W ScrollTo(string text)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is the commit. Obsolete code was removed.
Please remove this method.

@TikhomirovSergey
Copy link
Contributor

I hope that the Windoiws Mobile-specific searching will be provided ASAP on the server-side

TikhomirovSergey and others added 21 commits August 22, 2016 09:51
.NET Framework version was downgraded because of compatibility with Mono
Framework.However the lang level is 6.
Dependencies were updated:
- Selenium.WedDriver was upgraded to 2.53.1
- Selenium.Support was upgraded to 2.53.1
- Newtonsoft.Json was upgraded to 9.0.1
.NET Framework version was downgraded because of compatibility with Mono
Framework.However the lang level is 6.
These changes (#153 fix & #152 fix) are supposed to be the temporary
workaround. I'm and  @SrinivasanTarget are searching for a more relevant
solution. It seems it requires some changes on the server side

The `SessionDetails` property was added.  This property returns a
dictionary of the current session data.
It works against text input elements on Android.
@stoneman
Copy link
Contributor Author

Thanks for taking a look @jlipps and @TikhomirovSergey. I've addressed your comments but the git rebase -i I did to get rid of the merges seems to have changed the IDs of the commits I'd merged in from appium/appium-dotnet-driver. Is that expected? Will they be discarded if you merge in this PR? If not, I'll roll back but could do with some guidance on how to remove the merge commits cleanly.

@TikhomirovSergey
Copy link
Contributor

@JonStoneman
No. It is not expected. It seems you used a fork with very old code.
Please close this and open a new one which will contain only required changes.

One more question. Does it supports the searching by accesssibility Id? Could you provide an additional test?

@yodurr
Copy link
Contributor

yodurr commented Aug 22, 2016

Yes WinAppDriver supports searching by Accessibility ID. I'll add a test.

@TikhomirovSergey we're working on support for Win10 Mobile, for now this only supports Win10 PC. Thanks!

@stoneman
Copy link
Contributor Author

@TikhomirovSergey It's an old fork as most of the work to support Windows was done a long time ago. I'll create a new one and re-apply the changes.

@stoneman
Copy link
Contributor Author

Replaced by #158

@stoneman stoneman closed this Aug 23, 2016
@stoneman stoneman mentioned this pull request Aug 23, 2016
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants