Feature/win

[stoneman]

Change list

Add WindowsDriver and WindowsElement for use with https://github.com/appium/appium-windows-driver

Types of changes

What types of changes are you proposing/introducing to .NET client?
Put an x in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

Some methods throw NotImplementedExceptions due to https://github.com/Microsoft/WinAppDriver/ (and therefore https://github.com/appium/appium-windows-driver) not supporting the functionality.

[stoneman]

@yodurr Can you add the AccessibilityID test to this branch please?

[yodurr]

what about code like this in WindowsMultiSelectControlTest.cs? What other Accessibility ID API do you want to test?
AlarmClockSession.FindElementByAccessibilityId("AlarmPivotItem").Click();

Also I still don't follow why we need the IFindByWindowsUIAutomation namespace if the default API for finding by Accessibility ID works.

[stoneman]

@yodurr IFindByWindowsUIAutomation allows for much more complex queries than just locating an element by it's AccessibilityID. It could also allow for complex interactions. For example, here is an Android query that would scroll a scrollable view so that a view with a description containing my_description is made visible:

driver.FindElementByAndroidUIAutomator("new UiScrollable(new UiSelector().scrollable(true).instance(0)).scrollIntoView(new UiSelector().descriptionContains(\"my_description\").instance(0));");

@TikhomirovSergey Do you have any thoughts on this and are you happy with @yodurr's proposed AccessibilityId example test?

[TikhomirovSergey]

May be there is sence remove this string and make this string not commented

return CollectionConverterUnility.ConvertToExtendedWebElementCollection<W>(
                 this.FindElements("-windows uiautomation", selector));

It depends on server-side and when it would be available then it should work immediately

[TikhomirovSergey]

It looks ok. I want to publish one more (not major) build and then merge this PR.

I would like to ask you for a sample of the windows automation searching (you can post it as a comment).
Later it will be included to integration tests/

PS: I would like to add similar changes to the Java client with @JonStoneman authorship. Is it ok?

[TikhomirovSergey]

Please correct summary

[TikhomirovSergey]

@JonStoneman
I'm going to publish the v.2.0.1.1 on this weekend. And then I'm merging this PR.
There are conflicts. Sorry. It is my fault. I will resolve it on my own

[TikhomirovSergey]

@JonStoneman This PR was mergen successfully. Now you are free to develop it further. Also I'm going to improve some thing. Thank you for the contribution. I hope we will cooperate further. :)

[stoneman]

Great! - thanks @TikhomirovSergey :)