-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Windows devices #157
Conversation
👍 however lots of merges in the git log here |
Wow! |
@JonStoneman @yodurr |
return new WindowsElement(this, elementId); | ||
} | ||
|
||
public override W ScrollTo(string text) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is the commit. Obsolete code was removed.
Please remove this method.
I hope that the Windoiws Mobile-specific searching will be provided ASAP on the server-side |
…r, ICapabilities desiredCapabilities)
.NET Framework version was downgraded because of compatibility with Mono Framework.However the lang level is 6. Dependencies were updated: - Selenium.WedDriver was upgraded to 2.53.1 - Selenium.Support was upgraded to 2.53.1 - Newtonsoft.Json was upgraded to 9.0.1
.NET Framework version was downgraded because of compatibility with Mono Framework.However the lang level is 6.
These changes (#153 fix & #152 fix) are supposed to be the temporary workaround. I'm and @SrinivasanTarget are searching for a more relevant solution. It seems it requires some changes on the server side The `SessionDetails` property was added. This property returns a dictionary of the current session data.
It works against text input elements on Android.
Thanks for taking a look @jlipps and @TikhomirovSergey. I've addressed your comments but the |
@JonStoneman One more question. Does it supports the searching by accesssibility Id? Could you provide an additional test? |
Yes WinAppDriver supports searching by Accessibility ID. I'll add a test. @TikhomirovSergey we're working on support for Win10 Mobile, for now this only supports Win10 PC. Thanks! |
@TikhomirovSergey It's an old fork as most of the work to support Windows was done a long time ago. I'll create a new one and re-apply the changes. |
Replaced by #158 |
Change list
Add
WindowsDriver
andWindowsElement
for use with https://github.com/appium/appium-windows-driverTypes of changes
What types of changes are you proposing/introducing to .NET client?
Put an
x
in the boxes that applyDetails
Some methods throw NotImplementedExceptions due to https://github.com/Microsoft/WinAppDriver/ (and therefore https://github.com/appium/appium-windows-driver) not supporting the functionality.