Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve error message for invalid server url #1113

Merged
merged 2 commits into from Sep 29, 2023

Conversation

eglitise
Copy link
Collaborator

@eglitise eglitise commented Sep 27, 2023

This resolves #1071. The wording can probably still be improved.

@eglitise eglitise added the fix This resolves a user-facing problem label Sep 27, 2023
@eglitise
Copy link
Collaborator Author

Made some adjustments to showError to accept a new parameter. This allows enhancing the existing error message for invalid URL, instead of adding a second one.

@eglitise eglitise merged commit 9e09a1b into appium:main Sep 29, 2023
5 checks passed
@eglitise eglitise deleted the improve-wdio-wrong-url-error branch September 29, 2023 09:14
shiva-guntoju pushed a commit to shiva-guntoju/appium-inspector that referenced this pull request Feb 2, 2024
* feat: improve error message for invalid server url

* fix: further improve invalid server url messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix This resolves a user-facing problem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: Improve the generic error message for a wrong server url
2 participants