fix: improve error for invalid JSON in command argument #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KazuCocoa
approved these changes
Oct 25, 2023
mykola-mokhnach
approved these changes
Oct 25, 2023
mykola-mokhnach
approved these changes
Oct 26, 2023
mykola-mokhnach
approved these changes
Oct 26, 2023
shiva-guntoju
pushed a commit
to shiva-guntoju/appium-inspector
that referenced
this pull request
Feb 2, 2024
* fix: improve error for wrong JSON command argument * chore: address review comments * fix: show parsing error message in notification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when attempting to call the
executeScriptorupdateSettingscommand, if an invalid JSON argument is given, the app will return 2 errors - one for the invalid JSON, and another for the actual method execution.Changes included in this PR: