fix: adjust highlighters for Android tablets #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const [width, height] = deviceScreenSize.split('x'); | ||
| if (windowSize.height > windowSize.width) { // portrait mode | ||
| if ((windowSize.height > windowSize.width && height > width) || // phone portrait mode |
There was a problem hiding this comment.
should it be >= instead of > ?
There was a problem hiding this comment.
It's definitely an edgecase. If the dimensions are equal for both windowSize and deviceScreenSize, then either branch is fine. The only way problems could arise is if width == height, but windowSize.height != windowSize.width. I'm not sure how likely this is to actually happen.
There was a problem hiding this comment.
I'm also finding this condition a bit hard to read. Would it make more sense to reverse it?
There was a problem hiding this comment.
Created #1163 to adjust this
mykola-mokhnach
approved these changes
Oct 31, 2023
shiva-guntoju
pushed a commit
to shiva-guntoju/appium-inspector
that referenced
this pull request
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where element highlighters for Android tablets were being drawn incorrectly.
The core issue stems from the
deviceScreenSizeparameters, which appear to match portrait mode for phones, but landscape mode for tablets. This has now been adjusted for.Resolves #1154.