Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve various recorder issues #1187

Merged
merged 5 commits into from Nov 13, 2023
Merged

fix: resolve various recorder issues #1187

merged 5 commits into from Nov 13, 2023

Conversation

eglitise
Copy link
Collaborator

@eglitise eglitise commented Nov 9, 2023 •
edited

This PR fixes a few more issues with recorders that I noticed in the last few days:

  • Java: Fix parsing of capabilities in the appium:options format
    • Also fixes parsing of arrays
  • Java/Python: Change many methods deprecated in ruby_lib_core 7.3 to their mobile extension equivalents
  • Java/Python: Fix updateSettings
  • Java/Python: Replace Object.keys with _.map for readability
  • Java/Python/Ruby/Robot: When parsing a dictionary, remove pairs with undefined values
    • JS frameworks already handle this with JSON.stringify
  • JS: Add formatting for listing capabilities
  • Oxygen: Fix hardcoded mob platform type in findElement

@eglitise eglitise added the fix This resolves a user-facing problem label Nov 9, 2023
@eglitise eglitise merged commit 496f5ad into appium:main Nov 13, 2023
4 of 5 checks passed
@eglitise eglitise deleted the fix-more-recorder-issues branch November 13, 2023 18:52
shiva-guntoju pushed a commit to shiva-guntoju/appium-inspector that referenced this pull request Feb 2, 2024
@eglitise @shiva-guntoju
fix: resolve various recorder issues (appium#1187)
0e2e322 
* fix: resolve various recorder issues

* chore: remove unused method

* fix: format caps for JS recorder boilerplates

* fix: fix platform type in Oxygen findElement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KazuCocoa KazuCocoa KazuCocoa approved these changes

@jlipps jlipps Awaiting requested review from jlipps

@mykola-mokhnach mykola-mokhnach Awaiting requested review from mykola-mokhnach

Assignees
No one assigned
Labels
fix This resolves a user-facing problem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eglitise @KazuCocoa