Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve issue with Start Session sometimes needing a second click #1299

Merged
merged 2 commits into from Jan 22, 2024
Merged

fix: resolve issue with Start Session sometimes needing a second click #1299

merged 2 commits into from Jan 22, 2024

Conversation

orionlize
Copy link
Contributor

I found start session would throw error Invariant failed: A state mutation was detected between dispatches, in the path 'session.caps.0.name'. This may cause incorrect behavior. first time. function loadNewSession use caps directly would cause this bug.

This pr will fix this bug by cloneDeep(caps)

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jan 22, 2024 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

eglitise
eglitise reviewed Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@eglitise eglitise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this! I think this might fix #1255.
Could you please also sign the CLA?

app/renderer/components/Session/Session.js Outdated Show resolved Hide resolved
@orionlize
Copy link
Contributor Author

Thanks for spotting this! I think this might fix #1255. Could you please also sign the CLA?

done ;-)

@eglitise eglitise changed the title fix: function loadNewSession throw "A state mutation was detected bet… fix: resolve issue with Start Session sometimes needing a second click Jan 22, 2024
@eglitise
Copy link
Collaborator

Thank you!

@eglitise eglitise merged commit 65eeb68 into appium:main Jan 22, 2024
5 checks passed
shiva-guntoju pushed a commit to shiva-guntoju/appium-inspector that referenced this pull request Feb 2, 2024
@orionlize @shiva-guntoju
fix: resolve issue with Start Session sometimes needing a second click (
c91ee30 
appium#1299)

* fix: function loadNewSession throw "A state mutation was detected between dispatches"

* style: lodash import style
@eglitise eglitise added the fix This resolves a user-facing problem label Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eglitise eglitise eglitise left review comments

Assignees
No one assigned
Labels
fix This resolves a user-facing problem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@orionlize @eglitise