fix: improve scaling of screenshot width #1306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto improve-screenshot-width-scaling
mykola-mokhnach
approved these changes
Jan 29, 2024
shiva-guntoju
pushed a commit
to shiva-guntoju/appium-inspector
that referenced
this pull request
Feb 2, 2024
* fix: improve scaling of screenshot width * chore: cleanup * style: equalize flex-grow factors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the 500px hard limit for max screenshot width, and instead sets it to 40% of the window width. This allows for much better scaling at larger window widths.
I didn't notice any changes for portrait mode, but in landscape mode, with default window size, the screenshot was 9px wider (meaning the source/selected element is 9px narrower). I don't think this should negatively affect usability.
Should improve the situation for #1216.