chore: use .jsx and .module.css file extensions where appropriate #1444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykola-mokhnach
approved these changes
Apr 30, 2024
|
I'm OK with choosing Vite over Parcel v2! |
This was referenced May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a preparatory step towards (finally) migrating away from Parcel v1.
I've done a bit of experimenting on a fresh Electron+React project with Parcel v2, and it did not look great. Their Electron integration is unfortunately not as good as it could be, seemingly requiring a rewrite of some parts into CJS (though I didn't fully figure this part out).
Then I tried Webpack, but it required a lot of tinkering with its config files - too much for my limited knowledge.
Finally I tried Vite... and I actually managed to get it to work, for both web and Electron formats. So I am proposing to drop Parcel entirely and instead migrate to Vite.
I already started working on this migration, and managed to get the web version fully working (with one exception for i18n). But, as part of getting this to work, Vite required changing the extensions for React and CSS module files. Since this affected a lot of files, I thought of separating the changes into its own PR - and after some brief testing with Parcel v1, I did not observe any issues.