This repository has been archived by the owner on Oct 25, 2023. It is now read-only.
Require from global if opencv4nodejs is not found locally #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlipps
reviewed
Mar 1, 2019
There was a problem hiding this comment.
great idea, @imurchie, thanks. this has been bugging me. I always resorted to adding the global dir to my NODE_PATH in my zshrc, but that's an extra step for everyone.
i would consider exporting this, since we already need it for test-ai-classifier as well, for those who are using that feature.
changes LGTM but i agree with @mykola-mokhnach about the error cases.
| @@ -66,7 +66,7 @@ describe('image-util', function () { | |||
| }); | |||
|
|
|||
| describe('getImagesMatches', function () { | |||
| it('should calculate the number of matches between two images', async function () { | |||
| it.only('should calculate the number of matches between two images', async function () { // eslint-disable-line | |||
There was a problem hiding this comment.
Yes. Trying to get Windows working on Travis.
|
Ok. Once I get it stable and correct, I will make it exported. |
KazuCocoa
reviewed
Mar 2, 2019
lib/image-util.js
Outdated
| } | ||
|
|
||
| // find the npm global root | ||
| const cmd = `npm${isWindows() ? '.cmd' : ''}`; |
imurchie
force-pushed
the
isaac-opencv
branch
3 times, most recently
from
b563dc1
to
f3ac14b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node does not work as the code assumes it does. If a module is not found locally the system does not, by some magic, look at the globally installed modules (see nodejs/node#3865).
I tried to find a published package that does this but didn't find anything I was particularly confident of. And the actual code is pretty simple.
This PR adds a little utility function (currently not exported, since we don't have any need for it anywhere else) to find the global package and load it.
This ought to finally solve appium/appium#11865