This repository has been archived by the owner on Oct 25, 2023. It is now read-only.
Link global opencv4nodejs to give access #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - npm install --no-save mjpeg-consumer | ||
| script: | ||
| - npm run test | ||
| - npm run e2e-test | ||
| - npm run test && npm run e2e-test |
There was a problem hiding this comment.
don't we want to run e2e test if test fails?
There was a problem hiding this comment.
Not particularly. I'd rather the feedback earlier.
Also, if people aren't circumventing the pre-commit hooks, then the unit tests will always pass.
| @@ -58,6 +58,7 @@ | |||
| "scripts": { | |||
| "clean": "rm -rf node_modules && rm -f package-lock.json && npm install", | |||
| "prepare": "gulp prepublish", | |||
| "postinstall": "npm ls -g opencv4nodejs --depth=0 && npm link opencv4nodejs", | |||
There was a problem hiding this comment.
will it work for windows?
jlipps
approved these changes
Mar 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do not have the time right now to make the fully generalized solution proposed in #105. However, if
opencv4nodejsis already globally installed, it can be used by linking into this package. So check and link if it is there, after the install.