This repository has been archived by the owner on Oct 25, 2023. It is now read-only.
feat: export pluralize functionality #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/util.js
Outdated
| * | ||
| * @param {string} word - The word to pluralize | ||
| * @param {number} count - How many of the word exist | ||
| * @param {?boolean} inclusive - Whether to prefix with the number (e.g., 3 ducks) |
There was a problem hiding this comment.
inclusive [false]
I'd also think about putting all options into a dictionary, so we could extend it later if needed
mykola-mokhnach
approved these changes
Feb 6, 2020
lib/util.js
Outdated
| * @param {PluralizeOptions} options - options for word pluralization | ||
| * @returns {string} The word pluralized according to the number | ||
| */ | ||
| function pluralize (options = {}) { |
There was a problem hiding this comment.
the word and the count may stay as ordinary args, since they are always required
| inclusive = false, | ||
| } = options; | ||
| function pluralize (word, count, options = {}) { | ||
| let inclusive = false; |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add export of https://github.com/blakeembrey/pluralize through the
utilmodule.