feat: Make it possible to start UIA2 server without an app or a package id #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imurchie
reviewed
Sep 9, 2019
| @@ -190,12 +190,14 @@ class AndroidUiautomator2Driver extends BaseDriver { | |||
| // find and copy, or download and unzip an app url or path | |||
| this.opts.app = await this.helpers.configureApp(this.opts.app, [APK_EXTENSION, APKS_EXTENSION]); | |||
| await this.checkAppPresent(); | |||
| } else if (this.appOnDevice) { | |||
| } else if (this.opts.appPackage) { | |||
There was a problem hiding this comment.
Does this driver now take the appPackage from the app capability if it is there? Why not continue using this.appOnDevice?
There was a problem hiding this comment.
appOnDevice was a blind copy paste from AndroidDriver, which is not even assigned anywhere in UIA2
There was a problem hiding this comment.
Does this driver now take the appPackage from the app capability if it is there?
It was always like that:
// get appPackage et al from manifest if necessary
const appInfo = await helpers.getLaunchInfo(this.adb, this.opts);
// and get it onto our 'opts' object so we use it from now on
Object.assign(this.opts, appInfo || {});
There was a problem hiding this comment.
Ah. Getters don't get assigned like functions do. Alas.
KazuCocoa
approved these changes
Sep 9, 2019
There was a problem hiding this comment.
It's better to add this no app/appPackage case in https://github.com/appium/appium/blob/master/docs/en/drivers/android-uiautomator2.md
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.