Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update nodejs required verson, 'app' caps in uia2 and xcuitest #13265

Merged
merged 2 commits into from Sep 21, 2019

Conversation

KazuCocoa
Copy link
Member

Proposed changes

Types of changes

What types of changes does your code introduce to Appium?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@coveralls
Copy link

coveralls commented Sep 20, 2019

Coverage Status

Coverage remained the same at 89.391% when pulling b1fc260 on KazuCocoa:km/update-nodever-uia2 into 71b9876 on appium:master.

@KazuCocoa KazuCocoa changed the title docs: update nodejs required verson, uia2 docs: update nodejs required verson, 'app' caps in uia2 and xcuitest Sep 20, 2019
@KazuCocoa KazuCocoa merged commit aed49a8 into appium:master Sep 21, 2019
@KazuCocoa KazuCocoa deleted the km/update-nodever-uia2 branch September 21, 2019 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants