[Android] Search all by text

[bootstraponline]

> $driver.find_element :xpath, %(*[@text='Sign Out'])
post
session/a5ddd229-4c4a-4745-95d2-a8e7bcb28623/element
{"using":"xpath","value":"*[@text='Sign Out']"}
Selenium::WebDriver::Error::XPathLookupError: Could not parse xpath data from *[@text='Sign Out']

Android has [text contains](http://developer.android.com/tools/help/uiautomator/UiSelector.html#textContains(java.lang.String\)) so that should work.

[bootstraponline]

diff --git a/uiautomator/bootstrap/src/io/appium/android/bootstrap/AndroidCommandHolder.java b/uiautomator/bootstrap/src/io/appium/android/bootstrap/
index 0027561..ad18605 100644
--- a/uiautomator/bootstrap/src/io/appium/android/bootstrap/AndroidCommandHolder.java
+++ b/uiautomator/bootstrap/src/io/appium/android/bootstrap/AndroidCommandHolder.java
@@ -220,14 +220,11 @@ class AndroidCommandHolder {
     private static UiSelector selectorForFind(String strategy, String selector, Boolean many) throws InvalidStrategyException, AndroidCommandExcepti
         UiSelector s = new UiSelector();
         if (strategy.equals("tag name")) {
+        } else if (strategy.equals("text")) {
+            s = s.textContains(selector);
         } else if (strategy.equals("name")) {
             s = s.description(selector);
         } else {
@@ -241,4 +238,4 @@ class AndroidCommandHolder {
         return s;
     }

-}
\ No newline at end of file
+}

This works. Some selenium bindings will not accept finding by text so it should probably be placed under xpath.

[bootstraponline]

"//*[contains(@text, 'Sign Out')]" I think that's the proper XPath. This works in chrome

$x("//*[contains(@href,'favico')]")

Appium can't parse it though.

> $driver.find_element :xpath, %(//*[contains(@text, 'agree')])
post
session/a691485b-f94a-43a2-9ad2-3d113816b863/element
{"using":"xpath","value":"//*[contains(@text, 'agree')]"}
Selenium::WebDriver::Error::XPathLookupError: Could not parse xpath data from //*[contains(@text, 'agree')]

[bootstraponline]

Is there a better place for this than XPath?

[jlipps]

we could use selenium's "link text".

also yeah xpath doesn't support * yet, but i imagine that it could... adding it to the feature list!

[bootstraponline]

we could use selenium's "link text".

Link text is defined as Find the link element with matching visible text. The type can be any element so I'm not sure that makes sense.

also yeah xpath doesn't support * yet, but i imagine that it could... adding it to the feature list!

What about a simple implementation like this? I think there's only one valid XPath to trigger this feature.

> rgx
"//*[contains(@text, 'agree')]"
> rgx.match("//\\*\\[contains\\(@text, '(.*)'\\)\\]")[1]
"agree"

[bootstraponline]

The fix seems simple enough for xpath.js.

  var root = "^(/?/?(?:[a-zA-Z]+|\\*))";

[bootstraponline]

Android messes it up.

$driver.find_element :xpath, %(//*[contains(@text, 'agree')])

info: [ANDROID] [info] Got data from client: {"cmd":"action","action":"find","params":{"strategy":"xpath","selector":"//*[contains(@text, 'agree')]","context":"","multiple":false,"path":[{"node":"*","search":"desc"}],"attr":"text","constraint":"agree","substr":true}}
info: [ANDROID] [info] Got command of type ACTION
info: [ANDROID] [info] Building xpath selector from attr text and constraint agree and substr true
info: [ANDROID] [info] s.className('android.widget.*').textContains('agree')

[bootstraponline]

I submitted #308 with a proper fix.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.