Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to use local authorize-ios #12015

Merged
merged 1 commit into from
Jan 21, 2019
Merged

Move to use local authorize-ios #12015

merged 1 commit into from
Jan 21, 2019

Conversation

imurchie
Copy link
Contributor

Proposed changes

authorize-ios has been moved into appium-ios-driver, the only place where it is needed. Now wire that into appium so it is exposed as a global executable, and update the documentation to remove the requirement to install the external package.

Global binaries installed:

→ ls -la /Users/isaac/.nvm/versions/node/v11.3.0/bin
total 39872
drwxr-xr-x 7 isaac staff      224 Jan 15 11:41 .
drwxr-xr-x 9 isaac staff      288 Jan 15 11:40 ..
lrwxr-xr-x 1 isaac staff       44 Jan 15 11:41 appium -> ../lib/node_modules/appium/build/lib/main.js
lrwxr-xr-x 1 isaac staff       58 Jan 15 11:41 authorize-ios -> ../lib/node_modules/appium/node_modules/.bin/authorize-ios
-rwxr-xr-x 1 isaac staff 40825008 Nov 27 00:17 node
lrwxr-xr-x 1 isaac staff       38 Nov 27 00:17 npm -> ../lib/node_modules/npm/bin/npm-cli.js
lrwxr-xr-x 1 isaac staff       38 Nov 27 00:17 npx -> ../lib/node_modules/npm/bin/npx-cli.js

This also exposes an npm script to do the same, for use in local installations from source.

See #7475

Types of changes

What types of changes does your code introduce to Appium?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@imurchie imurchie added this to the Sprint 30 milestone Jan 15, 2019
@@ -14,12 +14,6 @@

### 授权 iOS 设备给你的电脑

你要运行 `authorize-ios` 工具进行授权,可以通过 `npm` 去安装该工具,运行以下命令进行安装
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, you know Chinese

@imurchie imurchie merged commit fd4afca into master Jan 21, 2019
@imurchie imurchie deleted the isaac-authorize-ios branch January 21, 2019 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants