fix: stop printing caps twice on session start #13101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/grid-register.js
Outdated
| @@ -47,10 +47,10 @@ function postRequest (data, addr, port) { | |||
| } | |||
|
|
|||
| // Move Selenium 3 configuration properties to configuration object | |||
| if (!jsonObject.hasOwnProperty('configuration')) { | |||
| if (!Object.prototype.hasOwnProperty.call(jsonObject, 'configuration')) { | |||
There was a problem hiding this comment.
cannot we simply use _.has ?
mykola-mokhnach
approved these changes
Aug 21, 2019
| let configuration = {}; | ||
| for (let property in jsonObject) { | ||
| if (jsonObject.hasOwnProperty(property) && property !== 'capabilities') { | ||
| for (const property in jsonObject) { |
There was a problem hiding this comment.
_toPairs might also be easier to read here
KazuCocoa
approved these changes
Aug 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Remove generic logging of incoming capabilities, since this is now printed elsewhere.
Currently, logs are like
With this PR,
Types of changes
What types of changes does your code introduce to Appium?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.